Make http_body cross-platform

Make http_body cross-platform

'util' builds on Windows after this.

R=mark@chromium.org, rsesek@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9cfd2c515e6f709dbbd9837c0b4862411e50f601

[Mark Mentovai, 2014-12-19 21:38:27]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-12-19 21:38:28]

+rsesek also, he wrote this class.

[Robert Sesek, 2014-12-19 21:55:33]

LGTM

[Mark Mentovai, 2014-12-19 22:55:56]

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.cc
File util/net/http_body.cc (right):

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.cc#ne...
util/net/http_body.cc:49: : HTTPBodyStream(), path_(path),
file_state_(kUnopenedFile) {
Add an empty initializer for file_() before file_state_ (matching the reordered
declarations) so that its initialization is clear.

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.h
File util/net/http_body.h (right):

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.h#new...
util/net/http_body.h:95: 
Nit: blank line not necessary now that there’s no comment explaining the thing
that follows.

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.h#new...
util/net/http_body.h:96: FileState file_state_;
Nit: sort for optimal structure packing, file_ preceding file_state_.

[scottmg, 2014-12-19 22:58:34]

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.cc
File util/net/http_body.cc (right):

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.cc#ne...
util/net/http_body.cc:49: : HTTPBodyStream(), path_(path),
file_state_(kUnopenedFile) {
On 2014/12/19 22:55:55, Mark Mentovai wrote:
> Add an empty initializer for file_() before file_state_ (matching the
reordered
> declarations) so that its initialization is clear.

Done.

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.h
File util/net/http_body.h (right):

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.h#new...
util/net/http_body.h:95: 
On 2014/12/19 22:55:56, Mark Mentovai wrote:
> Nit: blank line not necessary now that there’s no comment explaining the thing
> that follows.

Done.

https://codereview.chromium.org/791493007/diff/60001/util/net/http_body.h#new...
util/net/http_body.h:96: FileState file_state_;
On 2014/12/19 22:55:55, Mark Mentovai wrote:
> Nit: sort for optimal structure packing, file_ preceding file_state_.

Done.

[Mark Mentovai, 2014-12-19 23:17:14]

LGTM

[scottmg, 2014-12-19 23:21:24]

Committed patchset #5 (id:80001) manually as
9cfd2c515e6f709dbbd9837c0b4862411e50f601 (presubmit successful).