sky/tools/debugger/trace_collector.cc - Issue 791493006: De-client tracing.TraceController interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tools/debugger/trace_collector.cc

Issue 791493006: De-client tracing.TraceController interface (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/tools/debugger/trace_collector.cc

diff --git a/sky/tools/debugger/trace_collector.cc b/sky/tools/debugger/trace_collector.cc

index 75345db46e382ff902551e59807cc694085eb11a..6232d7dab5af22dad93df5b7f38970907bc21dc4 100644

--- a/sky/tools/debugger/trace_collector.cc

+++ b/sky/tools/debugger/trace_collector.cc

@@ -15,7 +15,8 @@ TraceCollector::~TraceCollector() {

}

void TraceCollector::GetTrace(TraceCallback callback) {

- DCHECK(!callback_.is_null());

+ DCHECK(callback_.is_null());

+ DCHECK(!callback.is_null());

if (is_complete_) {

callback.Run(GetTraceAsString());

return;