LayoutTests/fast/repaint/horizontal-bt-overflow-child-expected.txt - Issue 791453007: Deflake repaint layout tests which assumed scroll would happen before first paint.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/repaint/horizontal-bt-overflow-child-expected.txt

Issue 791453007: Deflake repaint layout tests which assumed scroll would happen before first paint. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/repaint/horizontal-bt-overflow-child.html ('k') | LayoutTests/fast/repaint/horizontal-bt-overflow-parent.html » ('j') | LayoutTests/fast/repaint/resources/text-based-repaint.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "bounds": [800, 600],	2 "bounds": [800, 600],

3 "children": [	3 "children": [

4 {	4 {

5 "bounds": [800, 600],	5 "bounds": [800, 600],

6 "contentsOpaque": true,	6 "contentsOpaque": true,

7 "drawsContent": true,	7 "drawsContent": true,

8 "repaintRects": [	8 "repaintRects": [

9 [29, 106, 100, 100]	9 [29, 106, 100, 100],

	10 [29, 21, 285, 201],

	11 [29, 21, 100, 201],

	12 [29, 20, 285, 186],

	13 [29, 20, 100, 86]
	Xianzhu 2014/12/12 16:42:00 Could you explain this change? Could you explain this change? rmcilroy 2014/12/12 17:20:17 I'm assuming these are the invalidations which are Show quoted text On 2014/12/12 16:42:00, Xianzhu wrote: > Could you explain this change? I'm assuming these are the invalidations which are due to the scroll. Are you meaning the last invalidation in particular? Xianzhu 2014/12/12 17:37:36 I mean all the new invalidations. The scroll happe Show quoted text On 2014/12/12 17:20:17, rmcilroy wrote: > On 2014/12/12 16:42:00, Xianzhu wrote: > > Could you explain this change? > > I'm assuming these are the invalidations which are due to the scroll. Are you > meaning the last invalidation in particular? I mean all the new invalidations. The scroll happens before the repaint test (and before a displayAsyncThen), so invalidations caused by the scroll should happen before we start tracking the invalidations and should not be in the result. Was this result generated when the scheduler was on or off? If it generates this result when scheduler is off, I'd like to debug and see what happened.
10 ]	14 ]

11 }	15 }

12 ]	16 ]

13 }	17 }

14	18

OLD	NEW