ui/app_list/views/search_box_view.cc - Issue 791403004: Prevent Shift+Tab from locking up the browser when in the app list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/search_box_view.cc

Issue 791403004: Prevent Shift+Tab from locking up the browser when in the app list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_result_display_recommendation

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/search_box_view.cc

diff --git a/ui/app_list/views/search_box_view.cc b/ui/app_list/views/search_box_view.cc

index a72414970c430a7812536963c4027a1b09208d4f..6af1ab6ffa4df2e52f9480e028e4ad6635f5199e 100644

--- a/ui/app_list/views/search_box_view.cc

+++ b/ui/app_list/views/search_box_view.cc

@@ -221,6 +221,9 @@ bool SearchBoxView::HandleKeyEvent(views::Textfield* sender,

if (contents_view_ && contents_view_->visible())

handled = contents_view_->OnKeyPressed(key_event);

+ if (key_event.key_code() == ui::VKEY_TAB && key_event.IsShiftDown())

Matt Giuca 2014/12/14 22:40:30 Copy some text from the CL description to a commen

calamity 2014/12/15 02:37:12 Done.

+ handled = true;

return handled;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »