Issue 791393003: Add onBackgroundColorChanged to Tab and TabObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 791393003: Add onBackgroundColorChanged to Tab and TabObserver (Closed)

Created:
6 years ago by Yusuf

Modified:
6 years ago

Reviewers:
Ted C

CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add onBackgroundColorChanged to Tab and TabObserver onBackgroundColor is currently coming through ContentViewCore. The downstream counterpart to this will remove the downstream notification. BUG=344589 Committed: https://crrev.com/8ae1a697225b649dcbfe2ed7199329c87839779a Cr-Commit-Position: refs/heads/master@{#307990}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/Tab.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791393003/1

6 years ago (2014-12-11 21:00:32 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-11 23:10:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8ae1a697225b649dcbfe2ed7199329c87839779a
Cr-Commit-Position: refs/heads/master@{#307990}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages