Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 791393002: Fix coredump in Accessibility Manager SetProfile on shutdown. (Closed)

Created:
6 years ago by Ivan Podogov
Modified:
6 years ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Dmitry Polukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix coredump in Accessibility Manager SetProfile on shutdown. BUG=none Committed: https://crrev.com/bda078cff49cde6e654da3a7bd4f41230cc7fe96 Cr-Commit-Position: refs/heads/master@{#308345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ivan Podogov
When shutting down, chromeos::AccessibilityManager::SetProfile is called as SetProfile(NULL). At the end of this function number ...
6 years ago (2014-12-11 14:00:48 UTC) #2
David Tseng
lgtm
6 years ago (2014-12-11 21:09:09 UTC) #3
Ivan Podogov
6 years ago (2014-12-12 14:56:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791393002/1
6 years ago (2014-12-15 13:37:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 14:25:02 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 14:25:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bda078cff49cde6e654da3a7bd4f41230cc7fe96
Cr-Commit-Position: refs/heads/master@{#308345}

Powered by Google App Engine
This is Rietveld 408576698