Add type annotations to gallery/js/image_editor/image_util.js.

Add type annotations to gallery/js/image_editor/image_util.js.

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "image_util.js"

Committed: https://crrev.com/99bcfb1bbbd9d0d4a335fb22afc4fe439756b9ed
Cr-Commit-Position: refs/heads/master@{#308057}

[yawano, 2014-12-11 11:07:36]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2014-12-11 11:07:37]

PTAL. Thanks!

[fukino, 2014-12-11 11:28:16]

Thanks!

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:157: * TODO(yawano) Remove
createWith calls and call constructor directly.
nit: We usually use semicolon after the name, like TODO(yawano): Remo...

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:164: // TODO(yawano)
Change getters to methods (e.g. getRight()).
ditto

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:540: if ('imageTransform'
in fetchedMediaMetadata) {
Does "if (fetchedMediaMetadata.imageTransform)" have a problem?

[yawano, 2014-12-12 01:11:33]

Thank you for the review. PTAL.

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:157: * TODO(yawano) Remove
createWith calls and call constructor directly.
On 2014/12/11 11:28:16, fukino wrote:
> nit: We usually use semicolon after the name, like TODO(yawano): Remo...

Done.

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:164: // TODO(yawano)
Change getters to methods (e.g. getRight()).
On 2014/12/11 11:28:15, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/791363003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:540: if ('imageTransform'
in fetchedMediaMetadata) {
On 2014/12/11 11:28:15, fukino wrote:
> Does "if (fetchedMediaMetadata.imageTransform)" have a problem?

Done.
I didn't know that we can write in this way with closure compiler. Thank you!

[fukino, 2014-12-12 02:21:03]

https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:540: if
(fetchedMediaMetadata.imageTransform)
Do we need this if statement? That is, did onTransform(this.image_,
fetchedMediaMetadata.imageTransform) not work?

[yawano, 2014-12-12 03:17:45]

Thank you for the review!

https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:540: if
(fetchedMediaMetadata.imageTransform)
On 2014/12/12 02:21:03, fukino wrote:
> Do we need this if statement? That is, did onTransform(this.image_,
> fetchedMediaMetadata.imageTransform) not work?

If we write it as onTransform(this.image_, fetchedMediaMetadata.imageTransform),
the compiler tells the error that imageTransform is not defined on
fetchedMediaMetadata.

[fukino, 2014-12-12 05:03:44]

Thanks! lgtm.

https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:540: if
(fetchedMediaMetadata.imageTransform)
On 2014/12/12 03:17:45, yawano wrote:
> On 2014/12/12 02:21:03, fukino wrote:
> > Do we need this if statement? That is, did onTransform(this.image_,
> > fetchedMediaMetadata.imageTransform) not work?
> 
> If we write it as onTransform(this.image_,
fetchedMediaMetadata.imageTransform),
> the compiler tells the error that imageTransform is not defined on
> fetchedMediaMetadata.

Got it.

[yawano, 2014-12-12 05:05:34]

On 2014/12/12 05:03:44, fukino wrote:
> Thanks! lgtm.
> 
>
https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
> File ui/file_manager/gallery/js/image_editor/image_util.js (right):
> 
>
https://codereview.chromium.org/791363003/diff/60001/ui/file_manager/gallery/...
> ui/file_manager/gallery/js/image_editor/image_util.js:540: if
> (fetchedMediaMetadata.imageTransform)
> On 2014/12/12 03:17:45, yawano wrote:
> > On 2014/12/12 02:21:03, fukino wrote:
> > > Do we need this if statement? That is, did onTransform(this.image_,
> > > fetchedMediaMetadata.imageTransform) not work?
> > 
> > If we write it as onTransform(this.image_,
> fetchedMediaMetadata.imageTransform),
> > the compiler tells the error that imageTransform is not defined on
> > fetchedMediaMetadata.
> 
> Got it.

Thank you!

[yawano, 2014-12-12 05:05:38]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-12-12 05:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791363003/60001

[commit-bot: I haz the power, 2014-12-12 06:19:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-12 06:21:03]

Patchset 4 (id:??) landed as
https://crrev.com/99bcfb1bbbd9d0d4a335fb22afc4fe439756b9ed
Cr-Commit-Position: refs/heads/master@{#308057}