Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 791353002: Fix WeakPtrFactory member ordering in gpu (Closed)

Created:
6 years ago by anujsharma
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in gpu Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/e75b97e2d6797a635d8c4b3237d92668fd9f3b20 Cr-Commit-Position: refs/heads/master@{#308010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years ago (2014-12-11 09:55:29 UTC) #2
piman
lgtm
6 years ago (2014-12-11 18:17:44 UTC) #3
anujsharma
On 2014/12/11 18:17:44, piman (Very slow to review) wrote: > lgtm Thanks piman for lgtm.
6 years ago (2014-12-11 23:13:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791353002/1
6 years ago (2014-12-11 23:16:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 00:36:55 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 00:38:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e75b97e2d6797a635d8c4b3237d92668fd9f3b20
Cr-Commit-Position: refs/heads/master@{#308010}

Powered by Google App Engine
This is Rietveld 408576698