Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 791273002: App list: Lighten the mouse and keyboard highlight colours. (Closed)

Created:
6 years ago by Matt Giuca
Modified:
6 years ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

App list: Lighten the mouse and keyboard highlight colours. Provides better contrast with the downloads bar while remaining contrasted with the background. BUG=424067 Committed: https://crrev.com/15aff38bf7ea99bcf414018240dea84d88e31067 Cr-Commit-Position: refs/heads/master@{#308317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/app_list/app_list_constants.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Matt Giuca
Decision was made on: https://code.google.com/p/chromium/issues/detail?id=424067#c18
6 years ago (2014-12-14 23:28:16 UTC) #2
calamity
lgtm fy
6 years ago (2014-12-15 01:35:24 UTC) #3
Matt Giuca
What is fy?
6 years ago (2014-12-15 01:47:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791273002/1
6 years ago (2014-12-15 01:48:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/18201)
6 years ago (2014-12-15 03:23:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791273002/1
6 years ago (2014-12-15 04:59:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 05:35:16 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-15 05:36:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15aff38bf7ea99bcf414018240dea84d88e31067
Cr-Commit-Position: refs/heads/master@{#308317}

Powered by Google App Engine
This is Rietveld 408576698