dart/pkg/compiler/lib/src/apiimpl.dart - Issue 791263003: Remove Compiler.reportFatalError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/pkg/compiler/lib/src/apiimpl.dart

Issue 791263003: Remove Compiler.reportFatalError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: One more crash revealed. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/pkg/compiler/lib/src/apiimpl.dart

diff --git a/dart/pkg/compiler/lib/src/apiimpl.dart b/dart/pkg/compiler/lib/src/apiimpl.dart

index 8567fb3f6538c995386242e259016304308e035f..a92725e77f1ac2bfdd6e562e7623911a380ec83b 100644

--- a/dart/pkg/compiler/lib/src/apiimpl.dart

+++ b/dart/pkg/compiler/lib/src/apiimpl.dart

@@ -310,8 +310,9 @@ class Compiler extends leg.Compiler {

Uri translatePackageUri(leg.Spannable node, Uri uri) {

if (packageRoot == null) {

- reportFatalError(

+ reportError(

node, leg.MessageKind.PACKAGE_ROOT_NOT_SET, {'uri': uri});

+ throw new CompilerCancelledException(null);

Johnni Winther 2015/01/06 08:12:04 Insert a TODO. This shouldn't be fatal, but behave

ahe 2015/01/07 12:55:24 Actually, this is a misuse of the compiler API. I'

}

return packageRoot.resolve(uri.path);

}