Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: src/v8natives.js

Issue 791243002: Stop sending Object.observe notifications for API accessor properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Restore most of v8natives Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8natives.js
diff --git a/src/v8natives.js b/src/v8natives.js
index 44ad6de622fc73e7687259b23e7b0a388537b993..ac96f6391edb1b5377bc169da210e5053f827c93 100644
--- a/src/v8natives.js
+++ b/src/v8natives.js
@@ -887,15 +887,6 @@ function DefineArrayProperty(obj, p, desc, should_throw) {
break;
}
}
- // Make sure the below call to DefineObjectProperty() doesn't overwrite
- // any magic "length" property by removing the value.
- // TODO(mstarzinger): This hack should be removed once we have addressed the
- // respective TODO in Runtime_DefineDataPropertyUnchecked.
adamk 2014/12/11 20:26:07 This TODO was taken care of by r21558, so at least
- // For the time being, we need a hack to prevent Object.observe from
- // generating two change records.
- obj.length = new_length;
- desc.value_ = UNDEFINED;
- desc.hasValue_ = false;
threw = !DefineObjectProperty(obj, "length", desc, should_throw) || threw;
if (emit_splice) {
EndPerformSplice(obj);
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698