Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 791233003: Generate OnPipelineSeeked event for seek to currenttime in pause state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 06eaa5a104eb3f993d563fbcf4951484d5090021..5d3b8aae5c12f39a318e68d661537036dd7e8023 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -327,17 +327,20 @@ void WebMediaPlayerImpl::seek(double seconds) {
media_log_->AddEvent(media_log_->CreateSeekEvent(seconds));
// Update our paused time.
- // In paused state ignore the seek operations to current time and generate
- // buffer state change event to eventually fire seeking and seeked events
+ // In paused state ignore the seek operations to current time and mock
DaleCurtis 2014/12/12 23:00:52 mock has a special connotation in Chrome, so keep
Srirama 2014/12/13 04:23:42 Done.
+ // OnPipelineSeeked and OnPipelineBufferingStateChanged events
+ // to eventually fire seeking and seeked events
if (paused_) {
if (paused_time_ != seek_time) {
paused_time_ = seek_time;
} else {
main_task_runner_->PostTask(
+ FROM_HERE, base::Bind(&WebMediaPlayerImpl::OnPipelineSeeked,
DaleCurtis 2014/12/12 23:00:52 This may result in changing the paused_time_ if Ge
Srirama 2014/12/13 04:23:42 ok
+ AsWeakPtr(), false, PIPELINE_OK));
+ main_task_runner_->PostTask(
FROM_HERE,
base::Bind(&WebMediaPlayerImpl::OnPipelineBufferingStateChanged,
- AsWeakPtr(),
- BUFFERING_HAVE_ENOUGH));
+ AsWeakPtr(), BUFFERING_HAVE_ENOUGH));
return;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698