Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 791233003: Generate OnPipelineSeeked event for seek to currenttime in pause state (Closed)

Created:
6 years ago by Srirama
Modified:
6 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate OnPipelineSeeked event for seek to currenttime in pause state Pipeline generates OnPipelineSeeked and OnPipelineBufferingStateChanged events in response to seek operations. There is an event generated already for OnPipelineBufferingStateChanged but missing one for OnPipelineSeeked. Follow up fix for https://codereview.chromium.org/740663002/ Required for landing https://codereview.chromium.org/456343002/ Committed: https://crrev.com/8f4a375654e361ff368474f19d0221cb751cee68 Cr-Commit-Position: refs/heads/master@{#308263}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Modified comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Srirama
The test media/controls-restrained-media-controller.html is failing in https://codereview.chromium.org/456343002/ We need this patch to mimic the actual ...
6 years ago (2014-12-12 14:56:37 UTC) #2
DaleCurtis
https://codereview.chromium.org/791233003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/791233003/diff/1/media/blink/webmediaplayer_impl.cc#newcode330 media/blink/webmediaplayer_impl.cc:330: // In paused state ignore the seek operations to ...
6 years ago (2014-12-12 23:00:52 UTC) #3
DaleCurtis
lgtm % comment change.
6 years ago (2014-12-12 23:01:06 UTC) #4
Srirama
https://codereview.chromium.org/791233003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/791233003/diff/1/media/blink/webmediaplayer_impl.cc#newcode330 media/blink/webmediaplayer_impl.cc:330: // In paused state ignore the seek operations to ...
6 years ago (2014-12-13 04:23:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791233003/40001
6 years ago (2014-12-13 05:22:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years ago (2014-12-13 08:16:24 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-13 08:17:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f4a375654e361ff368474f19d0221cb751cee68
Cr-Commit-Position: refs/heads/master@{#308263}

Powered by Google App Engine
This is Rietveld 408576698