Issue 7912: Property enumeration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7912: Property enumeration (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

Added v8::Object::GetProperties method that returns an array of all the enumerable properties of an object.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	src/api.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-23 10:13:26 UTC) #2

LGTM, maybe with a better name?

http://codereview.chromium.org/7912/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/7912/diff/1/2#newcode1025
Line 1025: Local<Array> GetProperties();
Should this have a comment that describes what this function does (like the fact
that you only get enumerable properties back)? I think it should be renamed to
GetPropertyKeys, so it's clear you're not getting the values back.

Expand Messages | Collapse Messages