Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 791143002: Fix to set correct output type when blending when we've read dst (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix to set correct output type when blending when we've read dst BUG=skia: Committed: https://skia.googlesource.com/skia/+/733fc2054044377e914559fa4f46db66ab7d9cea

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : nits #

Patch Set 4 : Update genkey #

Patch Set 5 : Merging follow up fix cls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -228 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 1 2 3 4 3 chunks +26 lines, -6 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 2 3 4 5 chunks +41 lines, -3 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 2 3 4 3 chunks +68 lines, -18 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrOptDrawState.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 3 4 3 chunks +6 lines, -37 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 2 3 4 4 chunks +1 line, -40 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 3 4 7 chunks +119 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 4 5 chunks +6 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 4 8 chunks +20 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 3 4 2 chunks +10 lines, -5 lines 0 comments Download
A src/gpu/gl/GrGLXferProcessor.h View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
M src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 4 7 chunks +23 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 6 chunks +53 lines, -12 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 3 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
egdaniel
This fix is to unblock the roll. Manually checked it on linux blink layout test ...
6 years ago (2014-12-10 20:34:54 UTC) #2
bsalomon
lgtm
6 years ago (2014-12-10 20:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791143002/60001
6 years ago (2014-12-10 20:36:07 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/733fc2054044377e914559fa4f46db66ab7d9cea
6 years ago (2014-12-10 20:45:25 UTC) #6
joshualitt
6 years ago (2014-12-10 22:56:32 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/795783002/ by joshualitt@google.com.

The reason for reverting is: Breaks DM on windows.

Powered by Google App Engine
This is Rietveld 408576698