Delegates for the printing component

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 79bc401e1934d29c26f97a5724ef645b89341508..7f9125cdea189fe741109bc0445788f5a61da159 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -49,6 +49,7 @@
 #include "chrome/renderer/prerender/prerender_media_load_deferrer.h"
 #include "chrome/renderer/prerender/prerenderer_client.h"
 #include "chrome/renderer/principals_extension_bindings.h"
+#include "chrome/renderer/printing/chrome_print_web_view_helper_delegate.h"
 #include "chrome/renderer/printing/print_web_view_helper.h"
 #include "chrome/renderer/safe_browsing/malware_dom_details.h"
 #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
@@ -506,7 +507,12 @@ void ChromeContentRendererClient::RenderViewCreated(
 #endif
   new PageLoadHistograms(render_view);
 #if defined(ENABLE_PRINTING)
-  new printing::PrintWebViewHelper(render_view);
+  print_web_view_helper_delegate_.reset(new ChromePrintWebViewHelperDelegate());
+  new printing::PrintWebViewHelper(
+      render_view,
+      print_web_view_helper_delegate_->OutOfProcessPdfEnabled(),
+      print_web_view_helper_delegate_->PrintPreviewDisabled(),
+      print_web_view_helper_delegate_.get());

[Lei Zhang, 2015/01/06 04:11:32]

Does the delegate outlive the PrintWebViewHelper?

[dgn, 2015/01/06 16:35:30]

Yes. From my understanding, when it is destroyed, render_view unregisters
PrintWebViewHelper which in turn also destroys itself. CCRendererClient outlives
them. The same system is used for other delegates in the files. I just did it
for consistency. That being said, I am also more comfortable with transferring
the ownership to PrintWebViewHelper (as done in PatchSet1). Is the new version
better?

[Vitaly Buka (NO REVIEWS), 2015/01/06 19:29:24]

I'd prefer to transfer ownership at it was in the first patch.


On 2015/01/06 16:35:30, dgn wrote:

 #endif
 #if defined(ENABLE_SPELLCHECK)
   new SpellCheckProvider(render_view, spellcheck_.get());