Issue 7911: Various API changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7911: Various API changes (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

- Added const in a few places. - Changed WeakReferenceCallback to take a Persistent<Value> instead of a Persistent<Object>. - Removed Message::GetUnderline and Message::GetScriptData. - Added Value::IsDate, Date::Cast and Date::Value.

Patch Set 1 #

Patch Set 2 : "Various API changes #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -134 lines)			Patch
M	include/v8.h	View	1	10 chunks	+27 lines, -23 lines	0 comments	Download
M	src/api.cc	View	1	10 chunks	+33 lines, -66 lines	0 comments	Download
M	src/debug.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+15 lines, -18 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+10 lines, -17 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	4 chunks	+13 lines, -4 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-23 08:13:15 UTC) #2

LGTM.

http://codereview.chromium.org/7911/diff/1/3
File src/api.cc (right):

http://codereview.chromium.org/7911/diff/1/3#newcode2495
Line 2495: double v8::Date::Value() {
Is this function really necessary? You can get the same result by converting it
to a number by using NumbeValue, right? Maybe it's okay for consistency.

Expand Messages | Collapse Messages