Browser tests for DevToolsBridgeClient.

Browser tests for DevToolsBridgeClient.

It tests device list updating mechanism mocking GCD server. Test code loads into a dummy page and
interacts with instance of DevToolsBridgeClient via dedicated command handler.

It also adds infrastacture for testing establishing sessions in future (ability to handle commands
sent from background_worker.html and create PeerConnection will help with it).

BUG=383418
Committed: https://crrev.com/5f7a3b1cff6b829b73020ccef1fb8435d0e3aee2
Cr-Commit-Position: refs/heads/master@{#309443}

[SeRya, 2014-12-19 15:38:20]

Patchset #3 (id:40001) has been deleted

[SeRya, 2014-12-19 15:39:10]

Patchset #2 (id:20001) has been deleted

[SeRya, 2014-12-20 15:07:44]

Patchset #3 (id:80001) has been deleted

[SeRya, 2014-12-20 16:28:16]

Patchset #3 (id:100001) has been deleted

[SeRya, 2014-12-20 17:39:22]

Patchset #4 (id:140001) has been deleted

[SeRya, 2014-12-20 18:24:16]

Patchset #3 (id:120001) has been deleted

[SeRya, 2014-12-20 18:24:22]

Patchset #2 (id:60001) has been deleted

[SeRya, 2014-12-20 19:06:02]

serya@chromium.org changed reviewers:
+ dgozman@chromium.org

[SeRya, 2014-12-20 19:06:02]

PTAL

[dgozman, 2014-12-22 16:38:21]

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client.h (right):

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client.h:71: // For tests.
Overridden in tests.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client.h:73: virtual void
OnBrowserListUpdated() {}
OnBrowserListUpdatedForTests

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc
(right):

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc:88:
"stub-user@example.com");
Make this string a local var, pass it twice and comment "DO NOT CHANGE".

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js
(right):

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:41:
createInstanceDef: function(id, displayName) {
JSDoc?

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:66:
request: function(id, body) {},
gcdApiRequest

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:80:
chrome.send('signIn', []);
Move this to signIn method.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:99:
chrome.send('response', [id, response]);
gcdApiResponse

[SeRya, 2014-12-22 17:00:15]

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client.h (right):

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client.h:71: // For tests.
On 2014/12/22 16:38:20, dgozman wrote:
> Overridden in tests.

Done.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client.h:73: virtual void
OnBrowserListUpdated() {}
On 2014/12/22 16:38:20, dgozman wrote:
> OnBrowserListUpdatedForTests

Done.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc
(right):

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc:88:
"stub-user@example.com");
On 2014/12/22 16:38:20, dgozman wrote:
> Make this string a local var, pass it twice and comment "DO NOT CHANGE".

Done.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js
(right):

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:41:
createInstanceDef: function(id, displayName) {
On 2014/12/22 16:38:21, dgozman wrote:
> JSDoc?

Done.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:66:
request: function(id, body) {},
On 2014/12/22 16:38:21, dgozman wrote:
> gcdApiRequest

Done.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:80:
chrome.send('signIn', []);
On 2014/12/22 16:38:21, dgozman wrote:
> Move this to signIn method.

Done.

https://codereview.chromium.org/791083005/diff/160001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:99:
chrome.send('response', [id, response]);
On 2014/12/22 16:38:21, dgozman wrote:
> gcdApiResponse

Done.

[dgozman, 2014-12-22 17:08:39]

lgtm

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client.h (right):

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client.h:74: const
BrowserInfoList& browsers() const { return browsers_; }
nit: please insert blank line before these, as they are not overridden in tests.

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc
(right):

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc:89:
test_->fake_signin_manager_->SetAuthenticatedUsername(
nit: this should fit one line.

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js
(right):

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:47:
* Creates GCD device definition with could be recognized as a DevToolsBridge.
typo: with -> which

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:111:
this.callbacksMock.expects(once()).browserListUpdated(3).will(
Let's make 3 a named constant, e.g. |var browsersCount = 3|.

[SeRya, 2014-12-22 17:14:43]

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client.h (right):

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client.h:74: const
BrowserInfoList& browsers() const { return browsers_; }
On 2014/12/22 17:08:38, dgozman wrote:
> nit: please insert blank line before these, as they are not overridden in
tests.

Done.

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc
(right):

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc:89:
test_->fake_signin_manager_->SetAuthenticatedUsername(
On 2014/12/22 17:08:38, dgozman wrote:
> nit: this should fit one line.

Reformatted CL

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
File chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js
(right):

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:47:
* Creates GCD device definition with could be recognized as a DevToolsBridge.
On 2014/12/22 17:08:38, dgozman wrote:
> typo: with -> which

Done.

https://codereview.chromium.org/791083005/diff/180001/chrome/browser/devtools...
chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js:111:
this.callbacksMock.expects(once()).browserListUpdated(3).will(
On 2014/12/22 17:08:38, dgozman wrote:
> Let's make 3 a named constant, e.g. |var browsersCount = 3|.

Done.

[SeRya, 2014-12-22 17:14:46]

The CQ bit was checked by serya@chromium.org

[commit-bot: I haz the power, 2014-12-22 17:15:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791083005/200001

[commit-bot: I haz the power, 2014-12-22 18:19:41]

Committed patchset #4 (id:200001)

[commit-bot: I haz the power, 2014-12-22 18:21:05]

Patchset 4 (id:??) landed as
https://crrev.com/5f7a3b1cff6b829b73020ccef1fb8435d0e3aee2
Cr-Commit-Position: refs/heads/master@{#309443}