Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 791083003: Add captive portal interstitial icons. (Closed)

Created:
6 years ago by meacer
Modified:
5 years, 11 months ago
Reviewers:
Bernhard Bauer, oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add captive portal interstitial icons. These icons are displayed inside captive portal blocking page. BUG=384667 Committed: https://crrev.com/6e3abef8679370042cb47d7e14fc5e99716fad15 Cr-Commit-Position: refs/heads/master@{#310720}

Patch Set 1 #

Patch Set 2 : Use the new icons in the css #

Total comments: 2

Patch Set 3 : Move images to resources/security_warnings/images #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A chrome/browser/resources/security_warnings/images/1x/captive_portal_page_icon.png View 1 2 Binary file 0 comments Download
A chrome/browser/resources/security_warnings/images/2x/captive_portal_page_icon.png View 1 2 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.css View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
meacer
oshima: Could you PTAL? These icons will replace the T-Rex in the screenshots: https://goo.gl/cnLIXQ
6 years ago (2014-12-19 23:34:30 UTC) #2
oshima
Did you forget to upload grd change?
6 years ago (2014-12-20 20:11:06 UTC) #3
meacer
Thanks. The files are referred directly from a .css page. Do I still need to ...
5 years, 12 months ago (2014-12-22 20:40:13 UTC) #4
meacer
oshima: Ping? Also +bauerb for chrome/browser/resources/security_warnings/interstitial_v2.css.
5 years, 11 months ago (2015-01-08 14:28:35 UTC) #6
oshima
https://codereview.chromium.org/791083003/diff/20001/chrome/browser/resources/security_warnings/interstitial_v2.css File chrome/browser/resources/security_warnings/interstitial_v2.css (right): https://codereview.chromium.org/791083003/diff/20001/chrome/browser/resources/security_warnings/interstitial_v2.css#newcode179 chrome/browser/resources/security_warnings/interstitial_v2.css:179: url(../../../app/theme/default_100_percent/common/captive_portal_page_icon.png) 1x, are you going to use these images ...
5 years, 11 months ago (2015-01-08 17:45:06 UTC) #7
Bernhard Bauer
CSS LGTM
5 years, 11 months ago (2015-01-08 21:40:22 UTC) #8
meacer
https://codereview.chromium.org/791083003/diff/20001/chrome/browser/resources/security_warnings/interstitial_v2.css File chrome/browser/resources/security_warnings/interstitial_v2.css (right): https://codereview.chromium.org/791083003/diff/20001/chrome/browser/resources/security_warnings/interstitial_v2.css#newcode179 chrome/browser/resources/security_warnings/interstitial_v2.css:179: url(../../../app/theme/default_100_percent/common/captive_portal_page_icon.png) 1x, On 2015/01/08 17:45:06, oshima wrote: > are ...
5 years, 11 months ago (2015-01-09 02:16:14 UTC) #9
oshima
lgtm (though I'm not the owner)
5 years, 11 months ago (2015-01-09 06:00:58 UTC) #10
meacer
Looks like Bernhard is, that's convenient :) Thanks!
5 years, 11 months ago (2015-01-09 06:07:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791083003/40001
5 years, 11 months ago (2015-01-09 06:08:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 06:50:26 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 06:51:29 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6e3abef8679370042cb47d7e14fc5e99716fad15
Cr-Commit-Position: refs/heads/master@{#310720}

Powered by Google App Engine
This is Rietveld 408576698