Issue 791043002: Oilpan: tidy up definition of some stack-allocated scope objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 791043002: Oilpan: tidy up definition of some stack-allocated scope objects. (Closed)

Created:
6 years ago by sof

Modified:
6 years ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, chromiumbugtracker_adobe.com, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, groby+blinkspell_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: tidy up definition of some stack-allocated scope objects. Have these keep a strong Member<> reference to their objects. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186941

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -6 lines)			Patch
M	Source/core/dom/NodeRenderingTraversal.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/editing/Editor.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/editing/InputMethodController.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791043002/1

6 years ago (2014-12-11 07:36:03 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-11 11:19:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186941

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages