Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 791033004: Control permission bubbles with Finch flag (Closed)

Created:
6 years ago by felt
Modified:
5 years, 11 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews, markusheintz_, leng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Control permission bubbles with Finch flag This adds a Finch trial that can enable and disable bubbles as needed. The flags will still override the Finch trial. BUG=364686 TEST= Visit https://adrifelt.github.io/bubble-demo.html and check to see if you get a permission bubbles or an infobar, depending on the setting: 1. Infobar: set chrome://flags/#enable-permissions-bubbles to 'Disabled' 2. Bubble: set chrome://flags/#enable-permissions-bubbles to 'Enabled' 3. Infobar: set chrome://flags/#enable-permissions-bubbles to 'Default' 4. Infobar: --force-fieldtrials=PermissionBubbleRollout/Disabled/ 5. Bubble: --force-fieldtrials=PermissionBubbleRollout/Enabled/ Committed: https://crrev.com/d1e598f62e1f25492b9fedf91b5ee2d07fa54102 Cr-Commit-Position: refs/heads/master@{#313351}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Default to false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.cc View 1 2 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
felt
Greg, PTAL. I'm prepping this CL to land as soon as all the tests are ...
6 years ago (2014-12-17 08:44:19 UTC) #2
Greg Billock
On 2014/12/17 08:44:19, felt wrote: > Greg, PTAL. I'm prepping this CL to land as ...
6 years ago (2014-12-17 17:19:49 UTC) #3
felt
On 2014/12/17 17:19:49, Greg Billock wrote: > On 2014/12/17 08:44:19, felt wrote: > > Greg, ...
6 years ago (2014-12-17 18:28:09 UTC) #4
Greg Billock
lgtm
6 years ago (2014-12-17 18:53:56 UTC) #5
felt
On 2014/12/17 18:53:56, Greg Billock wrote: > lgtm Hi Greg, I've modified this CL to ...
5 years, 11 months ago (2015-01-27 19:46:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791033004/40001
5 years, 11 months ago (2015-01-27 19:47:56 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-27 20:46:20 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:47:17 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1e598f62e1f25492b9fedf91b5ee2d07fa54102
Cr-Commit-Position: refs/heads/master@{#313351}

Powered by Google App Engine
This is Rietveld 408576698