Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 791033003: Tidy up UserMediaController references from mediastream request objects. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Tidy up UserMediaController references from mediastream request objects. References to the UserMediaController GCed object need to be traced; add missing Member<> refs + trace over these. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186932

Patch Set 1 #

Patch Set 2 : Fix non-Oilpan compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M Source/modules/mediastream/MediaDevicesRequest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaDevicesRequest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/mediastream/UserMediaController.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
Please take a look.
6 years ago (2014-12-10 22:13:25 UTC) #2
haraken
LGTM
6 years ago (2014-12-10 23:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791033003/1
6 years ago (2014-12-10 23:41:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/34731)
6 years ago (2014-12-11 00:01:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791033003/20001
6 years ago (2014-12-11 08:08:05 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 09:51:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186932

Powered by Google App Engine
This is Rietveld 408576698