components/autofill/core/browser/autofill_external_delegate.cc - Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate.h ('k') | components/autofill/core/browser/autofill_external_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc

index 51954b9afc2d6d851a4b8fed92e1d481dc702f8f..7bbdeec287bd1a3ac4b0a06fa94f8cb1ea5895f1 100644

--- a/components/autofill/core/browser/autofill_external_delegate.cc

+++ b/components/autofill/core/browser/autofill_external_delegate.cc

@@ -8,7 +8,6 @@

#include "components/autofill/core/browser/autocomplete_history_manager.h"

#include "components/autofill/core/browser/autofill_driver.h"

#include "components/autofill/core/browser/autofill_manager.h"

-#include "content/public/browser/web_contents.h"

#include "grit/component_strings.h"

#include "third_party/WebKit/public/web/WebAutofillClient.h"

#include "ui/base/l10n/l10n_util.h"

@@ -18,12 +17,11 @@ using blink::WebAutofillClient;

namespace autofill {

AutofillExternalDelegate::AutofillExternalDelegate(

- content::WebContents* web_contents,

AutofillManager* autofill_manager,

AutofillDriver* autofill_driver)

: autofill_manager_(autofill_manager),

autofill_driver_(autofill_driver),

- password_autofill_manager_(web_contents),

+ password_autofill_manager_(autofill_driver),

autofill_query_id_(0),

display_warning_if_disabled_(false),

has_autofill_suggestion_(false),