components/autofill/content/renderer/password_autofill_agent.h - Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index c426f0543b165bc37bb0f5608e3c5a75b5c362c7..503621bfda784a66f10f0c755a7f1af015e40b47 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -38,10 +38,10 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

bool TextFieldHandlingKeyDown(const blink::WebInputElement& element,

const blink::WebKeyboardEvent& event);

- // Fills the password associated with user name |value|. Returns true if the

- // username and password fields were filled, false otherwise.

+ // Fills the password associated with user name |username|. Returns true if

+ // the username and password fields were filled, false otherwise.

bool DidAcceptAutofillSuggestion(const blink::WebNode& node,

- const blink::WebString& value);

+ const blink::WebString& username);

// A no-op. Password forms are not previewed, so they do not need to be

// cleared when the selection changes. However, this method returns

// true when |node| is fillable by password Autofill.