Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: components/autofill/core/browser/password_autofill_manager_unittest.cc

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/password_autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/password_autofill_manager_unittest.cc b/components/autofill/core/browser/password_autofill_manager_unittest.cc
index 96ce202e614f5f935f097e841c876913abf8568f..2df433639c3bf163f16b344282fd422de877038e 100644
--- a/components/autofill/core/browser/password_autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/password_autofill_manager_unittest.cc
@@ -69,4 +69,8 @@ TEST_F(PasswordAutofillManagerTest, DidAcceptAutofillSuggestion) {
username_field(), ASCIIToUTF16(kAliceUsername)));
}
+// TODO(jeanfrancoisg): Add unittest checking that AutofillDriver's
blundell 2013/11/20 20:32:43 I think that you could just make a MockAutofillDri
jif-google 2013/11/21 16:46:02 Done.
+// RendererShouldAcceptPasswordAutofillSuggestion is called when calling
+// DidAcceptAutofillSuggestion. http://crbug.com/321721
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698