Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 79103002: Abstracted AcceptPasswordAutofillSuggestion IPC out of core Autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 16 matching lines...) Expand all
27 class AutofillManager; 27 class AutofillManager;
28 28
29 // TODO(csharp): A lot of the logic in this class is copied from autofillagent. 29 // TODO(csharp): A lot of the logic in this class is copied from autofillagent.
30 // Once Autofill is moved out of WebKit this class should be the only home for 30 // Once Autofill is moved out of WebKit this class should be the only home for
31 // this logic. See http://crbug.com/51644 31 // this logic. See http://crbug.com/51644
32 32
33 // Delegate for in-browser Autocomplete and Autofill display and selection. 33 // Delegate for in-browser Autocomplete and Autofill display and selection.
34 class AutofillExternalDelegate 34 class AutofillExternalDelegate
35 : public AutofillPopupDelegate { 35 : public AutofillPopupDelegate {
36 public: 36 public:
37 // Creates an AutofillExternalDelegate for the specified contents, 37 // Creates an AutofillExternalDelegate for the specified AutofillManager and
38 // AutofillManager, and AutofillDriver. 38 // AutofillDriver.
39 AutofillExternalDelegate(content::WebContents* web_contents, 39 AutofillExternalDelegate(AutofillManager* autofill_manager,
40 AutofillManager* autofill_manager,
41 AutofillDriver* autofill_driver); 40 AutofillDriver* autofill_driver);
42 virtual ~AutofillExternalDelegate(); 41 virtual ~AutofillExternalDelegate();
43 42
44 // AutofillPopupDelegate implementation. 43 // AutofillPopupDelegate implementation.
45 virtual void OnPopupShown() OVERRIDE; 44 virtual void OnPopupShown() OVERRIDE;
46 virtual void OnPopupHidden() OVERRIDE; 45 virtual void OnPopupHidden() OVERRIDE;
47 virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE; 46 virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;
48 virtual void DidSelectSuggestion(int identifier) OVERRIDE; 47 virtual void DidSelectSuggestion(int identifier) OVERRIDE;
49 virtual void DidAcceptSuggestion(const base::string16& value, 48 virtual void DidAcceptSuggestion(const base::string16& value,
50 int identifier) OVERRIDE; 49 int identifier) OVERRIDE;
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 std::vector<base::string16> data_list_labels_; 163 std::vector<base::string16> data_list_labels_;
165 164
166 base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_; 165 base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_;
167 166
168 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate); 167 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
169 }; 168 };
170 169
171 } // namespace autofill 170 } // namespace autofill
172 171
173 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_ 172 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autofill_driver.h ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698