Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: sky/engine/core/rendering/RenderLayerModelObject.cpp

Issue 791023006: Delete invalidateTreeIfNeeded. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove unneeded call Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderLayerModelObject.cpp
diff --git a/sky/engine/core/rendering/RenderLayerModelObject.cpp b/sky/engine/core/rendering/RenderLayerModelObject.cpp
index 65dfa643c2bcb9a92cdb6e031ba408bd19b1e318..5d11e952782e6c472a43c0f87affff65a7ea938c 100644
--- a/sky/engine/core/rendering/RenderLayerModelObject.cpp
+++ b/sky/engine/core/rendering/RenderLayerModelObject.cpp
@@ -98,9 +98,6 @@ void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderSt
if (!layer()) {
createLayer(type);
if (parent() && !needsLayout()) {
- // FIXME: This invalidation is overly broad. We should update to
- // do the correct invalidation at RenderStyle::diff time. crbug.com/349061
- layer()->renderer()->setShouldDoFullPaintInvalidation(true);
// FIXME: We should call a specialized version of this function.
layer()->updateLayerPositionsAfterLayout();
}
@@ -120,20 +117,5 @@ void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderSt
}
}
-void RenderLayerModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)
-{
- // FIXME: SVG should probably also go through this unified paint invalidation system.
- ASSERT(!needsLayout());
-
- if (!shouldCheckForPaintInvalidation(paintInvalidationState))
- return;
-
- const RenderLayerModelObject& newPaintInvalidationContainer = *adjustCompositedContainerForSpecialAncestors(&paintInvalidationState.paintInvalidationContainer());
- ASSERT(&newPaintInvalidationContainer == containerForPaintInvalidation());
-
- PaintInvalidationState childTreeWalkState(paintInvalidationState, *this, newPaintInvalidationContainer);
- RenderObject::invalidateTreeIfNeeded(childTreeWalkState);
-}
-
} // namespace blink
« no previous file with comments | « sky/engine/core/rendering/RenderLayerModelObject.h ('k') | sky/engine/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698