Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 791023006: Delete invalidateTreeIfNeeded. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove unneeded call Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.h ('k') | sky/engine/core/rendering/RenderImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index 7858a9e7374730d661d2d68fd9a533b898a138d5..410f24ef6594c4aad578a36e3aab8b9cdf20c767 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -92,9 +92,7 @@ void RenderBox::styleWillChange(StyleDifference diff, const RenderStyle& newStyl
// to dirty the render tree using the old position value now.
if (diff.needsFullLayout() && parent() && oldStyle->position() != newStyle.position()) {
markContainingBlocksForLayout();
- if (oldStyle->position() == StaticPosition)
- setShouldDoFullPaintInvalidation(true);
- else if (newStyle.hasOutOfFlowPosition())
+ if (newStyle.hasOutOfFlowPosition())
parent()->setChildNeedsLayout();
}
}
@@ -954,40 +952,6 @@ void RenderBox::paintFillLayer(const PaintInfo& paintInfo, const Color& c, const
paintFillLayerExtended(paintInfo, c, fillLayer, rect, bleedAvoidance, 0, LayoutSize(), backgroundObject, skipBaseColor);
}
-void RenderBox::imageChanged(WrappedImagePtr image, const IntRect*)
-{
- if (!parent())
- return;
-
- AllowPaintInvalidationScope scoper(frameView());
-
- if ((style()->borderImage().image() && style()->borderImage().image()->data() == image) ||
- (style()->maskBoxImage().image() && style()->maskBoxImage().image()->data() == image)) {
- setShouldDoFullPaintInvalidation(true);
- return;
- }
-
- if (!paintInvalidationLayerRectsForImage(image, style()->backgroundLayers(), true))
- paintInvalidationLayerRectsForImage(image, style()->maskLayers(), false);
-}
-
-bool RenderBox::paintInvalidationLayerRectsForImage(WrappedImagePtr image, const FillLayer& layers, bool drawingBackground)
-{
- RenderBox* layerRenderer = 0;
- if (drawingBackground && isDocumentElement())
- layerRenderer = view();
- else
- layerRenderer = this;
-
- for (const FillLayer* curLayer = &layers; curLayer; curLayer = curLayer->next()) {
- if (curLayer->image() && image == curLayer->image()->data() && curLayer->image()->canRender(*this)) {
- layerRenderer->setShouldDoFullPaintInvalidation(true);
- return true;
- }
- }
- return false;
-}
-
bool RenderBox::pushContentsClip(PaintInfo& paintInfo, const LayoutPoint& accumulatedOffset, ContentsClipBehavior contentsClipBehavior)
{
if (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == PaintPhaseSelfOutline || paintInfo.phase == PaintPhaseMask)
« no previous file with comments | « sky/engine/core/rendering/RenderBox.h ('k') | sky/engine/core/rendering/RenderImage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698