Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: sky/engine/core/rendering/RenderBlock.cpp

Issue 791023006: Delete invalidateTreeIfNeeded. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove unneeded call Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.h ('k') | sky/engine/core/rendering/RenderBlockFlow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBlock.cpp
diff --git a/sky/engine/core/rendering/RenderBlock.cpp b/sky/engine/core/rendering/RenderBlock.cpp
index 91f8249c1dd65db0672efb683e62ee1ca15771ea..c9fac7381efcf99232c086f01c2cbcf0d1a80674 100644
--- a/sky/engine/core/rendering/RenderBlock.cpp
+++ b/sky/engine/core/rendering/RenderBlock.cpp
@@ -220,26 +220,6 @@ void RenderBlock::styleDidChange(StyleDifference diff, const RenderStyle* oldSty
m_hasBorderOrPaddingLogicalWidthChanged = oldStyle && diff.needsFullLayout() && needsLayout() && borderOrPaddingLogicalWidthChanged(oldStyle, newStyle);
}
-void RenderBlock::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)
-{
- // Note, we don't want to early out here using shouldCheckForInvalidationAfterLayout as
- // we have to make sure we go through any positioned objects as they won't be seen in
- // the normal tree walk.
-
- RenderBox::invalidateTreeIfNeeded(paintInvalidationState);
-
- // Take care of positioned objects. This is required as PaintInvalidationState keeps a single clip rect.
- if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects()) {
- TrackedRendererListHashSet::iterator end = positionedObjects->end();
- const RenderLayerModelObject& newPaintInvalidationContainer = *adjustCompositedContainerForSpecialAncestors(&paintInvalidationState.paintInvalidationContainer());
- PaintInvalidationState childPaintInvalidationState(paintInvalidationState, *this, newPaintInvalidationContainer);
- for (TrackedRendererListHashSet::iterator it = positionedObjects->begin(); it != end; ++it) {
- RenderBox* box = *it;
- box->invalidateTreeIfNeeded(childPaintInvalidationState);
- }
- }
-}
-
void RenderBlock::addChildIgnoringAnonymousColumnBlocks(RenderObject* newChild, RenderObject* beforeChild)
{
if (beforeChild && beforeChild->parent() != this) {
@@ -506,9 +486,6 @@ void RenderBlock::layoutPositionedObjects(bool relayoutChildren, PositionedLayou
for (TrackedRendererListHashSet::iterator it = positionedDescendants->begin(); it != end; ++it) {
r = *it;
- // FIXME: this should only be set from clearNeedsLayout crbug.com/361250
- r->setLayoutDidGetCalled(true);
-
SubtreeLayoutScope layoutScope(*r);
// When a non-positioned block element moves, it may have positioned children that are implicitly positioned relative to the
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.h ('k') | sky/engine/core/rendering/RenderBlockFlow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698