Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: sky/engine/core/editing/InputMethodController.cpp

Issue 791023006: Delete invalidateTreeIfNeeded. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove unneeded call Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/editing/InputMethodController.cpp
diff --git a/sky/engine/core/editing/InputMethodController.cpp b/sky/engine/core/editing/InputMethodController.cpp
index 140f783b5dde0a5ac8d311276334756e131ded3f..5aa9515ae2afb2208119db3fc2898808637551e0 100644
--- a/sky/engine/core/editing/InputMethodController.cpp
+++ b/sky/engine/core/editing/InputMethodController.cpp
@@ -302,8 +302,11 @@ void InputMethodController::setComposition(const String& text, const Vector<Comp
m_customCompositionUnderlines[i].startOffset += baseOffset;
m_customCompositionUnderlines[i].endOffset += baseOffset;
}
+
+ // TODO(ojan): What was this for? Do we need it in sky since we
+ // don't need to support legacy IMEs?
if (baseNode->renderer())
- baseNode->renderer()->setShouldDoFullPaintInvalidation(true);
+ baseNode->renderer()->scheduleVisualUpdate();
unsigned start = std::min(baseOffset + selectionStart, extentOffset);
unsigned end = std::min(std::max(start, baseOffset + selectionEnd), extentOffset);
@@ -337,8 +340,12 @@ void InputMethodController::setCompositionFromExistingText(const Vector<Composit
m_customCompositionUnderlines[i].startOffset += m_compositionStart;
m_customCompositionUnderlines[i].endOffset += m_compositionStart;
}
+
+ // TODO(ojan): What was this for? Do we need it in sky since we
+ // don't need to support legacy IMEs?
if (baseNode->renderer())
- baseNode->renderer()->setShouldDoFullPaintInvalidation(true);
+ baseNode->renderer()->scheduleVisualUpdate();
+
return;
}
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698