Use event init dictionary in core/html/track

Use event init dictionary in core/html/track

This CL replaces manually-written TrackEventInit with
IDL dictionary. This CL also adds a constructor which
takes a RefPtr to subclasses of TrackBase. This constructor
is used to bypass TrackEventInit creation.

Tests under media/track and
fast/events/constructors/track-event-constructor.html cover
this change.

BUG=433179
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186845

[haraken, 2014-12-10 04:49:16]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2014-12-10 04:49:16]

LGTM

[bashi, 2014-12-10 07:13:28]

Patchset #1 (id:1) has been deleted

[philipj_slow, 2014-12-10 08:22:48]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2014-12-10 08:22:49]

LGTM with nit

https://codereview.chromium.org/790973002/diff/20001/Source/core/html/track/T...
File Source/core/html/track/TrackEvent.cpp (right):

https://codereview.chromium.org/790973002/diff/20001/Source/core/html/track/T...
Source/core/html/track/TrackEvent.cpp:46: if (track.isAudioTrack())
I'm guessing the compiler can't figure out that these are mutually exclusive by
itself, so use else if here and add ASSERT_UNREACHED at the end?

[bashi, 2014-12-10 08:45:56]

Thank you for reviews! I was about to ask for reviews:)

https://codereview.chromium.org/790973002/diff/20001/Source/core/html/track/T...
File Source/core/html/track/TrackEvent.cpp (right):

https://codereview.chromium.org/790973002/diff/20001/Source/core/html/track/T...
Source/core/html/track/TrackEvent.cpp:46: if (track.isAudioTrack())
On 2014/12/10 08:22:48, philipj wrote:
> I'm guessing the compiler can't figure out that these are mutually exclusive
by
> itself, so use else if here and add ASSERT_UNREACHED at the end?

Done. The compiler checks the type of the given value, but it can't figure out
they are subclass of TrackBase, so these conditions are needed.

...And I should have checked hasTrack() before using track().

[bashi, 2014-12-10 08:46:41]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-12-10 08:47:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790973002/40001

[commit-bot: I haz the power, 2014-12-10 11:32:24]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186845