LayoutTests/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right.html - Issue 790943004: An align attribute should not be applied for wider children

Side by Side Diff: LayoutTests/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right.html

Issue 790943004: An align attribute should not be applied for wider children (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebaseline the failed testcase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt ('k') | LayoutTests/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"	1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"

2 "http://www.w3.org/TR/html4/strict.dtd">	2 "http://www.w3.org/TR/html4/strict.dtd">

3 <!-- *** BEGIN LICENSE BLOCK ***	3 <!-- *** BEGIN LICENSE BLOCK ***

4 - Version: MPL 1.1/GPL 2.0/LGPL 2.1	4 - Version: MPL 1.1/GPL 2.0/LGPL 2.1

5 -	5 -

6 - The contents of this file are subject to the Mozilla Public License Version	6 - The contents of this file are subject to the Mozilla Public License Version

7 - 1.1 (the "License"); you may not use this file except in compliance with	7 - 1.1 (the "License"); you may not use this file except in compliance with

8 - the License. You may obtain a copy of the License at	8 - the License. You may obtain a copy of the License at

9 - http://www.mozilla.org/MPL/	9 - http://www.mozilla.org/MPL/

10 -	10 -

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 }	53 }

54 #inner {	54 #inner {

55 width:300px;	55 width:300px;

56 height:400px;	56 height:400px;

57 border: solid red 1px;	57 border: solid red 1px;

58 }	58 }

59 #target {	59 #target {

60	60

61 }	61 }

62 </style>	62 </style>

	63 <script src="../../../resources/js-test.js"></script>

63 </head>	64 </head>

64	65

65 <body>	66 <body>

66 <table border="1">	67 <table border="1">

67 <tr>	68 <tr>

68 <td id="spacer">foo</td>	69 <td id="spacer">foo</td>

69 <td id="target" align="right"><div id="outer"><div id="inner">d</div></div></t d>	70 <td id="target" align="right"><div id="outer"><div id="inner">d</div></div></t d>

70 </tr>	71 </tr>

71 </table>	72 </table>

72	73 <script>

	74 target = document.getElementById("target");

	75 shouldBe("target.getBoundingClientRect().left","128");
	Kyungtae Kim 2014/12/12 02:42:57 I need to rebaseline this test because it tests th I need to rebaseline this test because it tests the "overflowed align right". In this case, can I modify the test to have a common expected result like this, or should I add new expected results for all the ports? mstensho (USE GERRIT) 2014/12/15 09:27:48 The old expectations were wrong, and the new rende Show quoted text On 2014/12/12 02:42:57, Kyungtae Kim wrote: > I need to rebaseline this test because it tests the "overflowed align right". > In this case, can I modify the test to have a common expected result like this, > or should I add new expected results for all the ports? The old expectations were wrong, and the new rendering is correct. But I'm not sure how you can be sure that it should be 128. That would make assumptions about the font and the font engine. Besides, it's the position of #inner that you're really interested in, isn't it? I think it would be better to turn this test into a reftest. I don't know the history of this test (and the original commit in WebKit doesn't provide any useful info).
	76 </script>

73 </body>	77 </body>

74	78

75 </html>	79 </html>

OLD	NEW