Chromium Code Reviews Chromium Code Reviews
Issue 790943004:
An align attribute should not be applied for wider children (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 | |
| 3 <style> | |
| 4 body{margin:0px} | |
| 5 .narrow_block{width:100px} | |
| 6 .narrow_block>div{background:lime;width:200px;height:20px;border:1px solid black } | |
| 7 </style> | |
| 8 | |
| 9 <script src="../../resources/js-test.js"></script> | |
| 10 | |
| 11 <body> | |
|
mstensho (USE GERRIT)
2014/12/10 23:27:00
No need for the BODY tag, then.
Kyungtae Kim
2014/12/11 03:32:46
Done.
| |
| 12 <!-- Wider blocks inside the LTR block should be left-aligned regardless of alig n attribute --> | |
| 13 <div class="narrow_block"> | |
|
mstensho (USE GERRIT)
2014/12/10 23:27:00
How about an align="left" here?
Kyungtae Kim
2014/12/11 03:32:46
Done.
| |
| 14 <div dir="rtl" id="rtl_in_ltr_left"></div> | |
| 15 <div dir="ltr" id="ltr_in_ltr_left"></div> | |
| 16 </div> | |
| 17 | |
| 18 <div align="right" class="narrow_block"> | |
| 19 <div dir="rtl" id="rtl_in_ltr_right"></div> | |
| 20 <div dir="ltr" id="ltr_in_ltr_right"></div> | |
| 21 </div> | |
| 22 | |
| 23 <div align="center" class="narrow_block"> | |
| 24 <div dir="rtl" id="rtl_in_ltr_center"></div> | |
| 25 <div dir="ltr" id="ltr_in_ltr_center"></div> | |
| 26 </div> | |
| 27 | |
| 28 <!-- Wider blocks inside the RTL block should be left-aligned regardless of alig n attribute --> | |
|
mstensho (USE GERRIT)
2014/12/10 23:27:00
"left-aligned" -> "right-aligned"
Kyungtae Kim
2014/12/11 03:32:47
Done.
| |
| 29 <div dir="rtl" class="narrow_block"> | |
|
mstensho (USE GERRIT)
2014/12/10 23:27:00
How about an align="right" here?
Kyungtae Kim
2014/12/11 03:32:46
Done.
| |
| 30 <div dir="rtl" id="rtl_in_rtl_right"></div> | |
| 31 <div dir="ltr" id="ltr_in_rtl_right"></div> | |
| 32 </div> | |
| 33 | |
| 34 <div dir="rtl" align="left" class="narrow_block"> | |
| 35 <div dir="rtl" id="rtl_in_rtl_left"></div> | |
| 36 <div dir="ltr" id="ltr_in_rtl_left"></div> | |
| 37 </div> | |
| 38 | |
| 39 <div dir="rtl" align="center" class="narrow_block"> | |
| 40 <div dir="rtl" id="rtl_in_rtl_center"></div> | |
| 41 <div dir="ltr" id="ltr_in_rtl_center"></div> | |
| 42 </div> | |
| 43 | |
| 44 <script> | |
| 45 rtl_in_ltr_left = document.getElementById("rtl_in_ltr_left"); | |
| 46 ltr_in_ltr_left = document.getElementById("ltr_in_ltr_left"); | |
| 47 shouldBe("rtl_in_ltr_left.getBoundingClientRect().left","0"); | |
| 48 shouldBe("ltr_in_ltr_left.getBoundingClientRect().left","0"); | |
| 49 | |
| 50 rtl_in_ltr_right = document.getElementById("rtl_in_ltr_right"); | |
| 51 ltr_in_ltr_right = document.getElementById("ltr_in_ltr_right"); | |
| 52 shouldBe("rtl_in_ltr_right.getBoundingClientRect().left","0"); | |
| 53 shouldBe("ltr_in_ltr_right.getBoundingClientRect().left","0"); | |
| 54 | |
| 55 rtl_in_ltr_center = document.getElementById("rtl_in_ltr_center"); | |
| 56 ltr_in_ltr_center = document.getElementById("ltr_in_ltr_center"); | |
| 57 shouldBe("rtl_in_ltr_center.getBoundingClientRect().left","0"); | |
| 58 shouldBe("ltr_in_ltr_center.getBoundingClientRect().left","0"); | |
| 59 | |
| 60 rtl_in_rtl_right = document.getElementById("rtl_in_rtl_right"); | |
| 61 ltr_in_rtl_right = document.getElementById("ltr_in_rtl_right"); | |
| 62 shouldBe("rtl_in_rtl_right.getBoundingClientRect().right","100"); | |
| 63 shouldBe("ltr_in_rtl_right.getBoundingClientRect().right","100"); | |
| 64 | |
| 65 rtl_in_rtl_left = document.getElementById("rtl_in_rtl_left"); | |
| 66 ltr_in_rtl_left = document.getElementById("ltr_in_rtl_left"); | |
| 67 shouldBe("rtl_in_rtl_left.getBoundingClientRect().right","100"); | |
| 68 shouldBe("ltr_in_rtl_left.getBoundingClientRect().right","100"); | |
| 69 | |
| 70 rtl_in_rtl_center = document.getElementById("rtl_in_rtl_center"); | |
| 71 ltr_in_rtl_center = document.getElementById("ltr_in_rtl_center"); | |
| 72 shouldBe("rtl_in_rtl_center.getBoundingClientRect().right","100"); | |
| 73 shouldBe("ltr_in_rtl_center.getBoundingClientRect().right","100"); | |
| 74 </script> | |
| 75 | |
| 76 </body> | |
| OLD | NEW |
