Add DumpAccessibilityEvents test framework.

Add DumpAccessibilityEvents test framework.

Currently works on Windows only, but designed to be cross-platform with
just a bit of effort.

BUG=440579
Committed: https://crrev.com/8531606ec6e5294559a8dd1bd04cbbcb63514dee
Cr-Commit-Position: refs/heads/master@{#308844}

[dmazzoni, 2014-12-09 23:36:51]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2014-12-16 07:21:26]

Friendly ping

[David Tseng, 2014-12-16 16:53:05]

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_event_recorder.cc (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.cc:1: // Copyright
(c) 2014 The Chromium Authors. All rights reserved.
nit: I been dinged on this one too: no (c)

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_event_recorder.h (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:1: // Copyright (c)
2014 The Chromium Authors. All rights reserved.
Ditto.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:10: #include
"content/browser/accessibility/browser_accessibility_manager.h"
Could you forward declare?

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:15: class
AccessibilityEventRecorder {
nit: document

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:21: const
std::vector<std::string>& GetEventLogs() { return event_logs_; }
nit: just event_logs()

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:21: const
std::vector<std::string>& GetEventLogs() { return event_logs_; }
nit: document

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_event_recorder_win.cc (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
Ditto.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:44: }
  // namespace

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:51: static
void CALLBACK WinEventHookThunk(
nit: document

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:133:
CHECK(SUCCEEDED(hr));
Maybe print out a message on failure with the above params for easier debugging.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:159: log += "
value=\"" + base::UTF16ToUTF8(value) + "\"";
Could you do a string printf for each of these (or probably not in general) to
make this more readable?

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:161:
event_logs_.push_back(log);
Can you get these events out of order?

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_tree_formatter.h (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_tree_formatter.h:81: void
set_show_ids(bool show_ids) { show_ids_ = show_ids; }
nit: document

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_tree_formatter_utils_win.cc
(right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_tree_formatter_utils_win.cc:338:
return AccessibilityRoleStateMap::GetInstance()->event_string_map[event_id];
AccessibilityRoleStateMap no longer seems like an adequate name?

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_events_browsertest.cc
(right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_events_browsertest.cc:25: //
?

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_events_browsertest.cc:33: void
AdditionalErrorLogging() override;
nit: document these

[dmazzoni, 2014-12-16 23:26:32]

Please don't forget to also review https://codereview.chromium.org/787813006/
that this change depends on. I split it up because that other change is just a
simple refactoring.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_event_recorder.cc (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.cc:1: // Copyright
(c) 2014 The Chromium Authors. All rights reserved.
On 2014/12/16 16:53:04, David Tseng wrote:
> nit: I been dinged on this one too: no (c)

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_event_recorder.h (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:1: // Copyright (c)
2014 The Chromium Authors. All rights reserved.
On 2014/12/16 16:53:04, David Tseng wrote:
> Ditto.

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:10: #include
"content/browser/accessibility/browser_accessibility_manager.h"
On 2014/12/16 16:53:04, David Tseng wrote:
> Could you forward declare?

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:15: class
AccessibilityEventRecorder {
On 2014/12/16 16:53:04, David Tseng wrote:
> nit: document

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder.h:21: const
std::vector<std::string>& GetEventLogs() { return event_logs_; }
On 2014/12/16 16:53:04, David Tseng wrote:
> nit: just event_logs()

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_event_recorder_win.cc (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/12/16 16:53:05, David Tseng wrote:
> Ditto.

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:44: }
On 2014/12/16 16:53:05, David Tseng wrote:
>   // namespace

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:51: static
void CALLBACK WinEventHookThunk(
On 2014/12/16 16:53:05, David Tseng wrote:
> nit: document

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:133:
CHECK(SUCCEEDED(hr));
On 2014/12/16 16:53:05, David Tseng wrote:
> Maybe print out a message on failure with the above params for easier
debugging.

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:159: log += "
value=\"" + base::UTF16ToUTF8(value) + "\"";
On 2014/12/16 16:53:05, David Tseng wrote:
> Could you do a string printf for each of these (or probably not in general) to
> make this more readable?

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_event_recorder_win.cc:161:
event_logs_.push_back(log);
On 2014/12/16 16:53:05, David Tseng wrote:
> Can you get these events out of order?

No, this is called synchronously.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_tree_formatter.h (right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_tree_formatter.h:81: void
set_show_ids(bool show_ids) { show_ids_ = show_ids; }
On 2014/12/16 16:53:05, David Tseng wrote:
> nit: document

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/accessibility_tree_formatter_utils_win.cc
(right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/accessibility_tree_formatter_utils_win.cc:338:
return AccessibilityRoleStateMap::GetInstance()->event_string_map[event_id];
On 2014/12/16 16:53:05, David Tseng wrote:
> AccessibilityRoleStateMap no longer seems like an adequate name?

Changed to AccessibilityEnumMap.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_events_browsertest.cc
(right):

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_events_browsertest.cc:25: //
On 2014/12/16 16:53:05, David Tseng wrote:
> ?

Done.

https://codereview.chromium.org/790943002/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_events_browsertest.cc:33: void
AdditionalErrorLogging() override;
On 2014/12/16 16:53:05, David Tseng wrote:
> nit: document these

These are overrides; see the base class.

[David Tseng, 2014-12-17 15:41:35]

lgtm

[dmazzoni, 2014-12-17 18:38:37]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-12-17 18:39:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790943002/120001

[commit-bot: I haz the power, 2014-12-17 19:49:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-12-17 19:50:08]

Patchset 7 (id:??) landed as
https://crrev.com/8531606ec6e5294559a8dd1bd04cbbcb63514dee
Cr-Commit-Position: refs/heads/master@{#308844}

[Cait (Slow), 2014-12-17 21:50:28]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/811213002/ by caitkp@chromium.org.

The reason for reverting is: Failing on Win7 x64 bots:

http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%28...

DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #1):
[ RUN      ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged
[3528:3920:1217/131127:60955425:FATAL:accessibility_event_recorder_win.cc(147)]
Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd
0000000016F90210 obj_id=-4 child_id=-1004

DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #2):
[ RUN      ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged
[3048:3524:1217/131600:61228380:FATAL:accessibility_event_recorder_win.cc(147)]
Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd
000000001E4B01E8 obj_id=-4 child_id=-1004

DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #3):
[ RUN      ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged
[2984:1592:1217/131601:61229628:FATAL:accessibility_event_recorder_win.cc(147)]
Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd
000000001663021A obj_id=-4 child_id=-1004

DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #4):
[ RUN      ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged
[3628:408:1217/131602:61230049:FATAL:accessibility_event_recorder_win.cc(147)]
Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd
0000000009890254 obj_id=-4 child_id=-1004.