IndexedDB: Cleanup to remove iterators and improve variable names

IndexedDB: Cleanup to remove iterators and improve variable names

Some cleanup:

* Replaced iterator with range based for loop.
* Renamed a few parameters/local variables to improve clarity:
  * ChromiumEnv::RestoreIfNecessary "result" param -> "dir_entries".
  * "dir_filepath" -> "dir_path"
  * ChromiumEnv::GetChildren "dir_string" -> "dir"
* Accepted some "git cl format" improvements.

Committed: https://crrev.com/d1fd3a078d668f6bcd7ae224bc81549ae98ba3c6
Cr-Commit-Position: refs/heads/master@{#308211}

[cmumford, 2014-12-12 18:11:16]

cmumford@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2014-12-12 18:14:33]

lgtm

https://codereview.chromium.org/790913003/diff/1/third_party/leveldatabase/en...
File third_party/leveldatabase/env_chromium.cc (right):

https://codereview.chromium.org/790913003/diff/1/third_party/leveldatabase/en...
third_party/leveldatabase/env_chromium.cc:628: for (const FilePath& backup :
backups_only) {
Why FilePath here but auto above (instead of std::string)?

(Just trying to establish a consistent heuristic! I don't have a personal
preference, since I'm so used to `var` in JS...)

[cmumford, 2014-12-12 21:35:10]

On 2014/12/12 18:14:33, jsbell wrote:
> lgtm
> 
>
https://codereview.chromium.org/790913003/diff/1/third_party/leveldatabase/en...
> File third_party/leveldatabase/env_chromium.cc (right):
> 
>
https://codereview.chromium.org/790913003/diff/1/third_party/leveldatabase/en...
> third_party/leveldatabase/env_chromium.cc:628: for (const FilePath& backup :
> backups_only) {
> Why FilePath here but auto above (instead of std::string)?
> 
> (Just trying to establish a consistent heuristic! I don't have a personal
> preference, since I'm so used to `var` in JS...)

Good question - I'm going to change it to std::string to be consistent. I'm
still adjusting what I feel is "right", and I think that sometimes auto can hide
the actual type - for no good reason.

[cmumford, 2014-12-12 21:45:51]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-12-12 21:46:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790913003/20001

[commit-bot: I haz the power, 2014-12-13 01:20:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-13 01:21:22]

Patchset 2 (id:??) landed as
https://crrev.com/d1fd3a078d668f6bcd7ae224bc81549ae98ba3c6
Cr-Commit-Position: refs/heads/master@{#308211}