Generalizing conditional compilation logic for systems with native utf8 locale.

base/base.gypi

Index: base/base.gypi
diff --git a/base/base.gypi b/base/base.gypi
index f9451662c086f77c3be269eeab051684bb344579..c2c9d47634aee3e31ef2f131aa2a118e8517ab45 100644
--- a/base/base.gypi
+++ b/base/base.gypi
@@ -979,6 +979,10 @@
           ['OS == "win" and >(nacl_untrusted_build)==1', {
               'sources/': [ ['exclude', '\\.h$'] ],
           }],
+          # Enable more direct string conversions on OS with native utf8 strings

[gunsch, 2014/12/10 01:28:52]

OS --> platforms

[halliwell, 2014/12/11 00:48:28]

Done.

+          ['OS=="mac" or OS=="ios" or <(chromeos)==1 or <(chromecast)==1', {

[gunsch, 2014/12/10 01:28:52]

no need to wrap the chromeos/chromecast variables in <(...), just:

chromeos==1 or chromecast==1

[rvargas (doing something else), 2014/12/10 21:06:50]

why the test for chromeos is not the same one as for mac (in other words,
OS=="chromeos")?

[Lei Zhang, 2014/12/10 22:25:15]

There's no OS==chromeos... yet. I vaguely remember base.gypi being a bit
special, and thus all the variables are early eval.

[halliwell, 2014/12/11 00:48:28]

Yep, without <(...) around variables, you get name 'xxx' is not defined errors.

+            'defines': ['SYSTEM_NATIVE_UTF8'],
+          }],
         ],
       }],
       ['base_i18n_target==1', {