Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: base/strings/sys_string_conversions_posix.cc

Issue 790903003: Generalizing conditional compilation logic for systems with native utf8 locale. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated BUILD.gn based on rvargas comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/files/file_path.cc ('k') | net/base/filename_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/sys_string_conversions.h" 5 #include "base/strings/sys_string_conversions.h"
6 6
7 #include <wchar.h> 7 #include <wchar.h>
8 8
9 #include "base/strings/string_piece.h" 9 #include "base/strings/string_piece.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 11
12 namespace base { 12 namespace base {
13 13
14 std::string SysWideToUTF8(const std::wstring& wide) { 14 std::string SysWideToUTF8(const std::wstring& wide) {
15 // In theory this should be using the system-provided conversion rather 15 // In theory this should be using the system-provided conversion rather
16 // than our ICU, but this will do for now. 16 // than our ICU, but this will do for now.
17 return WideToUTF8(wide); 17 return WideToUTF8(wide);
18 } 18 }
19 std::wstring SysUTF8ToWide(const StringPiece& utf8) { 19 std::wstring SysUTF8ToWide(const StringPiece& utf8) {
20 // In theory this should be using the system-provided conversion rather 20 // In theory this should be using the system-provided conversion rather
21 // than our ICU, but this will do for now. 21 // than our ICU, but this will do for now.
22 std::wstring out; 22 std::wstring out;
23 UTF8ToWide(utf8.data(), utf8.size(), &out); 23 UTF8ToWide(utf8.data(), utf8.size(), &out);
24 return out; 24 return out;
25 } 25 }
26 26
27 #if defined(OS_CHROMEOS) || defined(OS_ANDROID) 27 #if defined(SYSTEM_NATIVE_UTF8) || defined(OS_ANDROID)
28 // TODO(port): Consider reverting the OS_ANDROID when we have wcrtomb() 28 // TODO(port): Consider reverting the OS_ANDROID when we have wcrtomb()
29 // support and a better understanding of what calls these routines. 29 // support and a better understanding of what calls these routines.
30 30
31 // ChromeOS always runs in UTF-8 locale.
32 std::string SysWideToNativeMB(const std::wstring& wide) { 31 std::string SysWideToNativeMB(const std::wstring& wide) {
33 return WideToUTF8(wide); 32 return WideToUTF8(wide);
34 } 33 }
35 34
36 std::wstring SysNativeMBToWide(const StringPiece& native_mb) { 35 std::wstring SysNativeMBToWide(const StringPiece& native_mb) {
37 return SysUTF8ToWide(native_mb); 36 return SysUTF8ToWide(native_mb);
38 } 37 }
39 38
40 #else 39 #else
41 40
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 break; 151 break;
153 } 152 }
154 } 153 }
155 154
156 return out; 155 return out;
157 } 156 }
158 157
159 #endif // OS_CHROMEOS 158 #endif // OS_CHROMEOS
160 159
161 } // namespace base 160 } // namespace base
OLDNEW
« no previous file with comments | « base/files/file_path.cc ('k') | net/base/filename_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698