Generalizing conditional compilation logic for systems with native utf8 locale.

base/base.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'base_target': 0,
       'base_i18n_target': 0,
     },
@@ skipping 961 matching lines @@
               ['exclude', '^files/file_util_linux\\.cc$'],
               ['exclude', '^process/process_linux\\.cc$'],
               ['exclude', '^sys_info_linux\\.cc$'],
             ],
           }],
           # Remove all unnecessary files for build_nexe.py to avoid exceeding
           # command-line-string limitation when building NaCl on Windows.
           ['OS == "win" and >(nacl_untrusted_build)==1', {
               'sources/': [ ['exclude', '\\.h$'] ],
           }],
+          # Enable more direct string conversions on OS with native utf8 strings

[gunsch, 2014/12/10 01:28:52]

OS --> platforms

[halliwell, 2014/12/11 00:48:28]

Done.

+          ['OS=="mac" or OS=="ios" or <(chromeos)==1 or <(chromecast)==1', {

[gunsch, 2014/12/10 01:28:52]

no need to wrap the chromeos/chromecast variables in <(...), just:

chromeos==1 or chromecast==1

[rvargas (doing something else), 2014/12/10 21:06:50]

why the test for chromeos is not the same one as for mac (in other words,
OS=="chromeos")?

[Lei Zhang, 2014/12/10 22:25:15]

There's no OS==chromeos... yet. I vaguely remember base.gypi being a bit
special, and thus all the variables are early eval.

[halliwell, 2014/12/11 00:48:28]

Yep, without <(...) around variables, you get name 'xxx' is not defined errors.

+            'defines': ['SYSTEM_NATIVE_UTF8'],
+          }],
         ],
       }],
       ['base_i18n_target==1', {
         'defines': [
           'BASE_I18N_IMPLEMENTATION',
         ],
         'sources': [
           'i18n/base_i18n_export.h',
           'i18n/bidi_line_iterator.cc',
           'i18n/bidi_line_iterator.h',
@@ skipping 27 matching lines @@
           'i18n/time_formatting.h',
           'i18n/timezone.cc',
           'i18n/timezone.h',
           'i18n/utf8_validator_tables.cc',
           'i18n/utf8_validator_tables.h',
         ],
       }]
     ],
   },
 }