Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 790853007: Instrumenting InitializeInternal to find jank (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting InitializeInternal to find jank. Prior instrumentations showed that ProfileIOData::Init's jank happens in the call to InitializeInternal (8.6 jph). Instrumenting InitializeInternal. BUG=436671 Committed: https://crrev.com/03f3dc19b2ead69e4730367a5b15596e198520ee Cr-Commit-Position: refs/heads/master@{#308659}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mmenke comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 12 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
mmenke@, please review
6 years ago (2014-12-16 19:18:31 UTC) #2
mmenke
LGTM https://codereview.chromium.org/790853007/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/790853007/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode607 chrome/browser/profiles/profile_impl_io_data.cc:607: profile_params, main_backend); optional: Suggest one here, too, just ...
6 years ago (2014-12-16 19:25:19 UTC) #3
vadimt
https://codereview.chromium.org/790853007/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/790853007/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode607 chrome/browser/profiles/profile_impl_io_data.cc:607: profile_params, main_backend); On 2014/12/16 19:25:19, mmenke wrote: > optional: ...
6 years ago (2014-12-16 19:29:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790853007/20001
6 years ago (2014-12-16 19:31:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-16 20:27:45 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-16 20:28:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03f3dc19b2ead69e4730367a5b15596e198520ee
Cr-Commit-Position: refs/heads/master@{#308659}

Powered by Google App Engine
This is Rietveld 408576698