content/browser/web_contents/web_contents_impl.h - Issue 790843002: If the renderer drops a navigation, make sure the spinner doesn't spin endlessly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 790843002: If the renderer drops a navigation, make sure the spinner doesn't spin endlessly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_delegate.h ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/common/frame_messages.h » ('j') | content/common/frame_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 8e1c65719186c10b67c940f7db1b2df4e72556b3..a747fe8c9f3d4a9557951a8e017ea5c2f47ba498 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -352,6 +352,7 @@ class CONTENT_EXPORT WebContentsImpl

void RenderFrameDeleted(RenderFrameHost* render_frame_host) override;

void DidStartLoading(RenderFrameHost* render_frame_host,

bool to_different_document) override;

+ void DidStopLoading(RenderFrameHost* render_frame_host) override;

void SwappedOut(RenderFrameHost* render_frame_host) override;

void DidDeferAfterResponseStarted(

const TransitionLayerData& transition_data) override;

@@ -883,9 +884,6 @@ class CONTENT_EXPORT WebContentsImpl

// Calculates the progress of the current load and notifies the delegate.

void SendLoadProgressChanged();

- // Called once when the last frame on the page has stopped loading.

- void DidStopLoading(RenderFrameHost* render_frame_host);

// Misc non-view stuff -------------------------------------------------------

// Helper functions for sending notifications.