Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 790823003: Inherit propagation diff necessary for loaded web fonts. (Closed)

Created:
6 years ago by rune
Modified:
6 years ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Inherit propagation diff necessary for loaded web fonts. As the loading status is not part of the RenderStyle equality operator anymore, we need to explicitly check for the loading status to make the style propagation diff be different from NoChange. That is necessary to trigger a call to RenderObject::setStyle which in turn will call visualInvalidationDiff that will trigger a layout/paint for the loaded font. This is a regression from r186572. R=eae@chromium.org BUG=440271 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
A LayoutTests/fast/css/font-face-inherit-repaint.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/font-face-inherit-repaint-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
PTAL
6 years ago (2014-12-09 15:32:09 UTC) #1
eae
LGTM
6 years ago (2014-12-09 18:37:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790823003/1
6 years ago (2014-12-09 18:37:48 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-09 19:50:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186801

Powered by Google App Engine
This is Rietveld 408576698