Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issue 790823002: Revert of Use Surfaces on Windows, Linux, and Mac OS (Closed)

Created:
6 years ago by gab
Modified:
6 years ago
Reviewers:
jamesr, jbauman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, danakj, enne (OOO), weiliangc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Surfaces on Windows, Linux, and Mac OS (patchset #2 id:20001 of https://codereview.chromium.org/756453003/) Reason for revert: Playing whack-a-mole for http://crbug.com/440060 and this CL sounds like it could potentially cause the problems we're seeing on the Win7 bots (I'll unrevert if not). Original issue's description: > Use Surfaces on Windows, Linux, and Mac OS > > Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet. > > BUG=334090 > > Committed: https://crrev.com/9d3616042261b9c5aa8f13ba9ef45c1819850559 > Cr-Commit-Position: refs/heads/master@{#307130} TBR=piman@chromium.org,jamesr@chromium.org,jbauman@chromium.org NOTREECHECKS=true NOTRY=true BUG=334090, 440060 Committed: https://crrev.com/829fc9c4b14e33ed671fab23784459f307fc0536 Cr-Commit-Position: refs/heads/master@{#307475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
gab
Created Revert of Use Surfaces on Windows, Linux, and Mac OS
6 years ago (2014-12-09 15:21:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790823002/1
6 years ago (2014-12-09 15:22:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 15:22:57 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-09 15:24:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/829fc9c4b14e33ed671fab23784459f307fc0536
Cr-Commit-Position: refs/heads/master@{#307475}

Powered by Google App Engine
This is Rietveld 408576698