Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 790813005: Map -0 to integer 0 for typed array constructors. (Closed)

Created:
5 years, 11 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Map -0 to integer 0 for typed array constructors. R=bmeurer@chromium.org BUG=chromium:447756 LOG=Y Committed: https://crrev.com/a4124b3bfcf90cedbc6b84b5dec263ca369f6867 Cr-Commit-Position: refs/heads/master@{#26021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-447756.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 11 months ago (2015-01-12 11:14:31 UTC) #1
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-12 11:15:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790813005/1
5 years, 11 months ago (2015-01-12 11:15:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 11:42:55 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 11:44:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4124b3bfcf90cedbc6b84b5dec263ca369f6867
Cr-Commit-Position: refs/heads/master@{#26021}

Powered by Google App Engine
This is Rietveld 408576698