Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 790793008: chromeos: Remove unused private data members (Closed)

Created:
5 years, 11 months ago by hashimoto
Modified:
5 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove unused private data members To avoid having a lot of -Wunused-private-field warnings when using "=delete" to implement DISALLOW_COPY_AND_ASSIGN. BUG=447445 Committed: https://crrev.com/7da6008071b06ba9c734a0cba6979ea411b060d2 Cr-Commit-Position: refs/heads/master@{#310728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/modem_messaging_client.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/timezone/timezone_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/timezone/timezone_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/timezone/timezone_request.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/timezone/timezone_request.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/timezone/timezone_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
5 years, 11 months ago (2015-01-09 06:53:38 UTC) #2
satorux1
lgtm. good catch.
5 years, 11 months ago (2015-01-09 07:37:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790793008/1
5 years, 11 months ago (2015-01-09 07:41:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 07:45:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 07:46:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7da6008071b06ba9c734a0cba6979ea411b060d2
Cr-Commit-Position: refs/heads/master@{#310728}

Powered by Google App Engine
This is Rietveld 408576698