Mojo HTML viewer crash

mojo/services/html_viewer/html_document.cc

Index: mojo/services/html_viewer/html_document.cc
diff --git a/mojo/services/html_viewer/html_document.cc b/mojo/services/html_viewer/html_document.cc
index a99ec7d4a3c2c736758d1d4e6a48ffeb124a1c8d..0cc49cdabfa57a402bdfbe41e5e4f33c29aa39dc 100644
--- a/mojo/services/html_viewer/html_document.cc
+++ b/mojo/services/html_viewer/html_document.cc
@@ -240,9 +240,10 @@ blink::WebNavigationPolicy HTMLDocument::decidePolicyForNavigation(
   if (CanNavigateLocally(frame, request))
     return default_policy;
 
-  navigator_host_->RequestNavigate(
-      WebNavigationPolicyToNavigationTarget(default_policy),
-      mojo::URLRequest::From(request).Pass());
+  if (embedder_service_provider_.get())

[DaveMoore, 2014/12/19 23:56:13]

nit: There should be braces around this.

[Aaron Boodman, 2014/12/20 17:46:07]

Modify LazyInterfacePtr so that you can do navigator_host_.get(). It should
first test whether service_provider_ is set, and if not, return false before
doing anything else.

[dtapuska, 2015/01/05 18:41:24]

Done.

+    navigator_host_->RequestNavigate(
+        WebNavigationPolicyToNavigationTarget(default_policy),
+        mojo::URLRequest::From(request).Pass());
 
   return blink::WebNavigationPolicyIgnore;
 }
@@ -258,7 +259,8 @@ void HTMLDocument::didNavigateWithinPage(
     blink::WebLocalFrame* frame,
     const blink::WebHistoryItem& history_item,
     blink::WebHistoryCommitType commit_type) {
-  navigator_host_->DidNavigateLocally(history_item.urlString().utf8());
+  if (embedder_service_provider_.get())
+    navigator_host_->DidNavigateLocally(history_item.urlString().utf8());
 }
 
 void HTMLDocument::OnViewBoundsChanged(View* view,