Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 790783003: [Password Generation] Fix breakage that prevents filling of generated passwords (Closed)

Created:
6 years ago by Garrett Casto
Modified:
6 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, erikwright+watch_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Fix breakage that prevents filling of generated passwords This bug was introduced in the move from RenderViewHost -> RenderFrameHost. The Interactive UI test would have caught this, but was disabled for being flaky. I'm actively working on fixing that test, but given the severity of the problem it makes sense to check in the fix without waiting for the test to be fixed. BUG=440257 Committed: https://crrev.com/2baf737555fb43ee6296be5d2e2562b6f3562a24 Cr-Commit-Position: refs/heads/master@{#308173}

Patch Set 1 : #

Messages

Total messages: 11 (4 generated)
Garrett Casto
Evan - Autofill changes. Vaclav - Password changes.
6 years ago (2014-12-12 08:54:50 UTC) #3
vabr (Chromium)
LGTM. So the problem was for cases when the driver did not correspond to the ...
6 years ago (2014-12-12 09:17:22 UTC) #4
Evan Stade
lgtm, sorry for breakage and thanks for fix.
6 years ago (2014-12-12 19:47:12 UTC) #5
Garrett Casto
Vaclav - It actually failed on all frames as far as I could tell. Evan ...
6 years ago (2014-12-12 20:45:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790783003/20001
6 years ago (2014-12-12 20:47:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-12 21:59:30 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 22:01:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2baf737555fb43ee6296be5d2e2562b6f3562a24
Cr-Commit-Position: refs/heads/master@{#308173}

Powered by Google App Engine
This is Rietveld 408576698