Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 790773003: Upstream iOS SuggestionsServiceFactory (Closed)

Created:
6 years ago by sdefresne
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@436897.1
Project:
chromium
Visibility:
Public.

Description

Upstream iOS SuggestionsServiceFactory Introduce iOS-specific implementation of SuggestionsServiceFactory and an implementation of suggestions::ImageFetcher interface that uses image_fetcher::ImageFetcher. BUG=436897 Committed: https://crrev.com/8ebe7372a269dc6cae14d848a94ab9ac9a43b1a3 Cr-Commit-Position: refs/heads/master@{#308126}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -0 lines) Patch
M ios/chrome/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A ios/chrome/browser/suggestions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/chrome/browser/suggestions/image_fetcher_impl.h View 1 chunk +55 lines, -0 lines 0 comments Download
A ios/chrome/browser/suggestions/image_fetcher_impl.mm View 1 chunk +66 lines, -0 lines 0 comments Download
A ios/chrome/browser/suggestions/suggestions_service_factory.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/suggestions/suggestions_service_factory.mm View 1 chunk +83 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
sdefresne
droger: please take a look OWNERS for new dependencies added - erg: //components/keyed_service - mathp: ...
6 years ago (2014-12-11 16:28:00 UTC) #2
sdefresne
+stuartmorgan for OWNERS of dependency on //ios/web & //ios/public/provider/chrome
6 years ago (2014-12-11 16:29:38 UTC) #4
droger
lgtm
6 years ago (2014-12-11 16:40:32 UTC) #5
Mathieu
lgtm
6 years ago (2014-12-11 16:43:30 UTC) #6
Elliot Glaysher
I don't see any changes to components/keyed_services/
6 years ago (2014-12-11 18:34:27 UTC) #7
Mathieu
On 2014/12/11 18:34:27, Elliot Glaysher wrote: > I don't see any changes to components/keyed_services/ It's ...
6 years ago (2014-12-11 18:36:02 UTC) #8
Nico
skia dep lgtm
6 years ago (2014-12-11 18:42:37 UTC) #9
Elliot Glaysher
your factory lgtm
6 years ago (2014-12-11 18:43:14 UTC) #10
stuartmorgan
ios/ DEPS LGTM
6 years ago (2014-12-11 23:49:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790773003/20001
6 years ago (2014-12-12 17:53:06 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 18:33:02 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-12 18:33:56 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ebe7372a269dc6cae14d848a94ab9ac9a43b1a3
Cr-Commit-Position: refs/heads/master@{#308126}

Powered by Google App Engine
This is Rietveld 408576698