Blink side of the change to pass the system font metrics from the browser to the renderer on Windo…

Blink side of the change to pass the system font metrics from the browser to the renderer on Windows

This change is needed to support Win32K lockdown mode in the renderer
process which prevents it from making user32/gdi32 calls which call into
win32k.sys on Windows 8+. Currently the renderer process crashes in the
Win32K lockdown mode while attempting to retrieve system font metrics.

Changes in this patch are as below:-

1. Updated the WebFontRendering interface with static methods to set the
   menu font, small caption font and status font metrics.

2. These methods are implemented by the FontCache class on Windows.

3. Changed the RenderThemeChromiumFontProvider class to retrieve the
   font metrics from the FontCache class before querying the system
   for the same.

BUG=442158
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187943

[ananta, 2015-01-06 23:05:34]

ananta@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-01-06 23:13:57]

lgtm

https://codereview.chromium.org/790733005/diff/1/Source/platform/fonts/FontCa...
File Source/platform/fonts/FontCache.h (right):

https://codereview.chromium.org/790733005/diff/1/Source/platform/fonts/FontCa...
Source/platform/fonts/FontCache.h:179: static String s_menuFontFamilyName;
you might need to make these String* and allocate when they're set to avoid
creating static initializers.

[scottmg, 2015-01-06 23:15:23]

https://codereview.chromium.org/790733005/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp (right):

https://codereview.chromium.org/790733005/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp:113: fontFamily =
AtomicString(FontCache::smallCaptionFontFamily());
Since they're only used as AtomicString, maybe store as AtomicString instead of
String in FontCache?

[Timothy Loh, 2015-01-06 23:27:45]

s/WebKit/Blink/ in the patch title and description? :)

[ananta, 2015-01-06 23:30:16]

https://codereview.chromium.org/790733005/diff/1/Source/platform/fonts/FontCa...
File Source/platform/fonts/FontCache.h (right):

https://codereview.chromium.org/790733005/diff/1/Source/platform/fonts/FontCa...
Source/platform/fonts/FontCache.h:179: static String s_menuFontFamilyName;
On 2015/01/06 23:13:57, scottmg wrote:
> you might need to make these String* and allocate when they're set to avoid
> creating static initializers.

Makes sense. Done. Changed these to AtomicString*

[ananta, 2015-01-06 23:31:05]

On 2015/01/06 23:27:45, Timothy Loh wrote:
> s/WebKit/Blink/ in the patch title and description? :)

Done. Thanks for pointing that out. :)

[ananta, 2015-01-06 23:40:14]

ananta@chromium.org changed reviewers:
+ eae@chromium.org

[ananta, 2015-01-06 23:40:27]

+eae

[eae, 2015-01-06 23:44:59]

LGTM

[ananta, 2015-01-06 23:47:28]

ananta@chromium.org changed reviewers:
+ dglazkov@chromium.org

[ananta, 2015-01-06 23:47:55]

+dglazkov for Source owners.

[pdr., 2015-01-06 23:50:04]

On 2015/01/06 at 23:47:55, ananta wrote:
> +dglazkov for Source owners.

LGTM

[pdr., 2015-01-06 23:50:07]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-01-06 23:51:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790733005/20001

[commit-bot: I haz the power, 2015-01-07 04:25:09]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187943