Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 790723003: [DevTools] Fix DevToolsManagerTest.TestObserver (Closed)

Created:
6 years ago by vkuzkokov
Modified:
6 years ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix DevToolsManagerTest.TestObserver BUG=440120 Committed: https://crrev.com/8444156d64786c635aa6b67223c6c311851aa4c5 Cr-Commit-Position: refs/heads/master@{#308084}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/browser/devtools/devtools_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vkuzkokov
6 years ago (2014-12-11 19:14:35 UTC) #3
dgozman
https://codereview.chromium.org/790723003/diff/20001/content/browser/devtools/devtools_manager_unittest.cc File content/browser/devtools/devtools_manager_unittest.cc (right): https://codereview.chromium.org/790723003/diff/20001/content/browser/devtools/devtools_manager_unittest.cc#newcode389 content/browser/devtools/devtools_manager_unittest.cc:389: manager->SetUpForTest(scheduler.callback()); Move this to SetUp.
6 years ago (2014-12-12 12:51:09 UTC) #4
vkuzkokov
https://codereview.chromium.org/790723003/diff/20001/content/browser/devtools/devtools_manager_unittest.cc File content/browser/devtools/devtools_manager_unittest.cc (right): https://codereview.chromium.org/790723003/diff/20001/content/browser/devtools/devtools_manager_unittest.cc#newcode389 content/browser/devtools/devtools_manager_unittest.cc:389: manager->SetUpForTest(scheduler.callback()); On 2014/12/12 12:51:08, dgozman wrote: > Move this ...
6 years ago (2014-12-12 12:59:12 UTC) #5
dgozman
lgtm
6 years ago (2014-12-12 13:03:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790723003/40001
6 years ago (2014-12-12 13:06:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years ago (2014-12-12 14:52:23 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 14:53:19 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8444156d64786c635aa6b67223c6c311851aa4c5
Cr-Commit-Position: refs/heads/master@{#308084}

Powered by Google App Engine
This is Rietveld 408576698