Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 790723002: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed)

Created:
6 years ago by Sven Panne
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. Without that, it has a few false positives about out-of-bounds array accesses.

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M include/v8config.h View 1 6 chunks +17 lines, -0 lines 0 comments Download
M src/base/logging.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
6 years ago (2014-12-09 11:58:02 UTC) #2
Benedikt Meurer
LGTM
6 years ago (2014-12-09 12:00:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790723002/1
6 years ago (2014-12-09 12:03:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/1708)
6 years ago (2014-12-09 12:14:44 UTC) #7
skomski
I played a bit with the clang static analyzer and stumbled upon the same issues. ...
5 years, 3 months ago (2015-09-23 19:55:24 UTC) #8
Benedikt Meurer
5 years, 3 months ago (2015-09-24 08:44:45 UTC) #9
Message was sent while issue was closed.
Well I guess no one actually cared about this CL. So feel free to take over
responsibility for this.

Powered by Google App Engine
This is Rietveld 408576698